ci: rename release-vscode to release-lsp, remove binary workflow#21
ci: rename release-vscode to release-lsp, remove binary workflow#21
Conversation
📝 WalkthroughWalkthroughThis pull request consolidates two separate GitHub Actions workflows for releasing the iii-lsp-vscode VS Code extension into a single unified workflow. The dedicated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release-lsp.yml:
- Around line 78-82: The "Publish to VS Code Marketplace" step currently runs
npx `@vscode/vsce` publish which repackages source instead of using the pre-built
VSIX; update that step to pass --packagePath (pointing to the VSIX artifact
produced earlier, i.e., the file created in the build step on line 76) to npx
`@vscode/vsce` publish so the Marketplace upload uses the same pre-built VSIX as
OpenVSX and the GitHub Release, and keep the existing VSCE_PAT env usage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 00534758-a252-47ff-b91c-6fe138fc08e8
📒 Files selected for processing (2)
.github/workflows/release-lsp.yml.github/workflows/release-vscode.yml
💤 Files with no reviewable changes (1)
- .github/workflows/release-vscode.yml
| - name: Publish to VS Code Marketplace | ||
| if: needs.setup.outputs.dry_run != 'true' | ||
| env: | ||
| VSCE_PAT: ${{ secrets.VSCE_PAT }} | ||
| run: npx @vscode/vsce publish --pat "$VSCE_PAT" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
vsce publish --packagePath option to publish existing vsix
💡 Result:
To publish an already-built .vsix (instead of repackaging from the current folder), use vsce publish --packagePath:
# publish an existing VSIX
vsce publish --packagePath ./myext-1.2.3.vsix -p "$VSCE_PAT"--packagePath(alias-i) tellsvsce publishto upload existing .vsix file(s) (you can pass multiple paths). [1]- This is commonly used after creating a platform-specific VSIX with
vsce package --target ..., then publishing that VSIX via--packagePath. [2]
Notes
- You still need Marketplace credentials (PAT via
-p/VSCE_PAT, or Entra ID if you’re set up for that). [1]
Sources: [1] [2]
Use the pre-built VSIX for VS Code Marketplace publishing.
Line 82 runs vsce publish without --packagePath, causing it to re-package the extension from source instead of using the VSIX built in line 76. This creates an inconsistency where VS Code Marketplace receives a different package than OpenVSX (line 88) and the GitHub Release.
🔧 Proposed fix to use the pre-built VSIX
- name: Publish to VS Code Marketplace
if: needs.setup.outputs.dry_run != 'true'
env:
VSCE_PAT: ${{ secrets.VSCE_PAT }}
- run: npx `@vscode/vsce` publish --pat "$VSCE_PAT"
+ run: npx `@vscode/vsce` publish --packagePath iii-lsp-${{ needs.setup.outputs.version }}.vsix --pat "$VSCE_PAT"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/release-lsp.yml around lines 78 - 82, The "Publish to VS
Code Marketplace" step currently runs npx `@vscode/vsce` publish which repackages
source instead of using the pre-built VSIX; update that step to pass
--packagePath (pointing to the VSIX artifact produced earlier, i.e., the file
created in the build step on line 76) to npx `@vscode/vsce` publish so the
Marketplace upload uses the same pre-built VSIX as OpenVSX and the GitHub
Release, and keep the existing VSCE_PAT env usage.
1 participant
Summary
release-lsp.ymlbinary release workflow (was building Rust binaries)release-vscode.yml→release-lsp.yml(VSCode extension publish workflow)Test plan
Summary by CodeRabbit